Shared ground
2 Kings 12:1–3 opens Joash’s reign with the usual royal markers (start date keyed to Israel’s king, length of reign, capital city, and mother’s name). These details place his story in real time and space, not in a timeless moral tale.
The narrator then gives a moral evaluation: Joash “did what was right” in Yahweh’s eyes. That evaluation is immediately connected to Jehoiada the priest’s instruction, highlighting that royal faithfulness is portrayed as shaped by guidance and oversight, not only by personal resolve.
At the same time, the passage adds a clear qualification: the “high places” (high places) were not removed, and the people continued offering sacrifices and incense there. So even under a generally approved reign, worship practice remains mixed.
Where interpretation differs (only where needed)
The main question is what “all his days” refers to in v. 2. One reading takes it as Joash’s whole reign. Another reading understands it as “all the days that Jehoiada instructed him,” implying Joash’s right conduct lasted only as long as that priest’s influence remained.
A second, smaller question is how severe v. 3’s note is meant to be: whether it describes tolerated worship sites that could still be directed to Yahweh, or whether it signals a more serious ongoing failure to align worship with what Kings treats as proper.
Why the disagreement exists
The Hebrew phrasing in v. 2 can be read as attaching “all his days” either to Joash’s lifetime/reign or to the period of Jehoiada’s instruction, and the sentence links both ideas closely. Also, “high places” can refer to different kinds of local worship sites across Israel’s history, so readers debate what practices are assumed here.
What this passage clearly contributes
Explicitly, the text claims (1) Joash’s reign details, (2) a positive evaluation of his conduct before Yahweh, (3) that this is linked to Jehoiada’s instruction, and (4) that the high places remained active. Theologically, the passage contributes a recurring theme in Kings: a king can be assessed as generally “right,” while still leaving significant worship issues unresolved, resulting in a qualified or mixed picture rather than a simple verdict.